]> git.karo-electronics.de Git - linux-beck.git/commitdiff
hwmon: (adt7470) fix checkpatch issues
authorFrans Meulenbroeks <fransmeulenbroeks@gmail.com>
Sun, 8 Jan 2012 18:34:13 +0000 (19:34 +0100)
committerGuenter Roeck <guenter.roeck@ericsson.com>
Mon, 19 Mar 2012 01:26:40 +0000 (18:26 -0700)
fixed:
ERROR: that open brace { should be on the previous line
#1135: FILE: adt7470.c:1135:
+static struct attribute *adt7470_attr[] =
+{

ERROR: do not use assignment in if condition
#1279: FILE: adt7470.c:1279:
+ if ((err = sysfs_create_group(&client->dev.kobj, &data->attrs)))

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
drivers/hwmon/adt7470.c

index 5e10c79f2dfdb42e4e0e7d3f856ec34d220c61ce..b23efd9c232f313fb8cfb24144d57361ddd31d8a 100644 (file)
@@ -1131,8 +1131,7 @@ static SENSOR_DEVICE_ATTR(pwm3_auto_channels_temp, S_IWUSR | S_IRUGO,
 static SENSOR_DEVICE_ATTR(pwm4_auto_channels_temp, S_IWUSR | S_IRUGO,
                    show_pwm_auto_temp, set_pwm_auto_temp, 3);
 
-static struct attribute *adt7470_attr[] =
-{
+static struct attribute *adt7470_attr[] = {
        &dev_attr_alarm_mask.attr,
        &dev_attr_num_temp_sensors.attr,
        &dev_attr_auto_update_interval.attr,
@@ -1276,7 +1275,8 @@ static int adt7470_probe(struct i2c_client *client,
 
        /* Register sysfs hooks */
        data->attrs.attrs = adt7470_attr;
-       if ((err = sysfs_create_group(&client->dev.kobj, &data->attrs)))
+       err = sysfs_create_group(&client->dev.kobj, &data->attrs);
+       if (err)
                goto exit_free;
 
        data->hwmon_dev = hwmon_device_register(&client->dev);