fs: use helper bio_add_page() instead of open coding on bi_io_vec

Call pre-defined helper bio_add_page() instead of open coding for
iterating through bi_io_vec[]. Doing that, it's possible to make some
parts in filesystems and mm/page_io.c simpler than before.

Acked-by: Dave Kleikamp <shaggy@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park <dpark@posteo.net>
Signed-off-by: Ming Lin <ming.l@ssi.samsung.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

diff --git a/fs/buffer.c b/fs/buffer.c
index 7887bb46636817bd003087c44853a108803613c1..82283abb2795d95bd31d595809e7881ca43942a3 100644 (file)
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -3046,12 +3046,9 @@ static int submit_bh_wbc(int rw, struct buffer_head *bh,
 
        bio->bi_iter.bi_sector = bh->b_blocknr * (bh->b_size >> 9);
        bio->bi_bdev = bh->b_bdev;
-       bio->bi_io_vec[0].bv_page = bh->b_page;
-       bio->bi_io_vec[0].bv_len = bh->b_size;
-       bio->bi_io_vec[0].bv_offset = bh_offset(bh);
 
-       bio->bi_vcnt = 1;
-       bio->bi_iter.bi_size = bh->b_size;
+       bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh));
+       BUG_ON(bio->bi_iter.bi_size != bh->b_size);
 
        bio->bi_end_io = end_bio_bh_io_sync;
        bio->bi_private = bh;

diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index d301acfdb80ddf8e95b77fcffa0a2cce8b56e711..a69bdf2a108500ceddee89b80bfd7e34dcddf8e8 100644 (file)
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -1999,12 +1999,9 @@ static int lbmRead(struct jfs_log * log, int pn, struct lbuf ** bpp)
 
        bio->bi_iter.bi_sector = bp->l_blkno << (log->l2bsize - 9);
        bio->bi_bdev = log->bdev;
-       bio->bi_io_vec[0].bv_page = bp->l_page;
-       bio->bi_io_vec[0].bv_len = LOGPSIZE;
-       bio->bi_io_vec[0].bv_offset = bp->l_offset;
 
-       bio->bi_vcnt = 1;
-       bio->bi_iter.bi_size = LOGPSIZE;
+       bio_add_page(bio, bp->l_page, LOGPSIZE, bp->l_offset);
+       BUG_ON(bio->bi_iter.bi_size != LOGPSIZE);
 
        bio->bi_end_io = lbmIODone;
        bio->bi_private = bp;
@@ -2145,12 +2142,9 @@ static void lbmStartIO(struct lbuf * bp)
        bio = bio_alloc(GFP_NOFS, 1);
        bio->bi_iter.bi_sector = bp->l_blkno << (log->l2bsize - 9);
        bio->bi_bdev = log->bdev;
-       bio->bi_io_vec[0].bv_page = bp->l_page;
-       bio->bi_io_vec[0].bv_len = LOGPSIZE;
-       bio->bi_io_vec[0].bv_offset = bp->l_offset;
 
-       bio->bi_vcnt = 1;
-       bio->bi_iter.bi_size = LOGPSIZE;
+       bio_add_page(bio, bp->l_page, LOGPSIZE, bp->l_offset);
+       BUG_ON(bio->bi_iter.bi_size != LOGPSIZE);
 
        bio->bi_end_io = lbmIODone;
        bio->bi_private = bp;

diff --git a/mm/page_io.c b/mm/page_io.c
index 338ce68942a01eaefa0dcc4f49bee99e969950bf..b995a5ba5e8f13f49c049e99eface364148d5660 100644 (file)
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -33,12 +33,10 @@ static struct bio *get_swap_bio(gfp_t gfp_flags,
        if (bio) {
                bio->bi_iter.bi_sector = map_swap_page(page, &bio->bi_bdev);
                bio->bi_iter.bi_sector <<= PAGE_SHIFT - 9;
-               bio->bi_io_vec[0].bv_page = page;
-               bio->bi_io_vec[0].bv_len = PAGE_SIZE;
-               bio->bi_io_vec[0].bv_offset = 0;
-               bio->bi_vcnt = 1;
-               bio->bi_iter.bi_size = PAGE_SIZE;
                bio->bi_end_io = end_io;
+
+               bio_add_page(bio, page, PAGE_SIZE, 0);
+               BUG_ON(bio->bi_iter.bi_size != PAGE_SIZE);
        }
        return bio;
 }