]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: wilc1000: wilc_deinit(): fixes inconsistent returns
authorLeo Kim <leo.kim@atmel.com>
Mon, 21 Dec 2015 05:18:26 +0000 (14:18 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Dec 2015 21:20:04 +0000 (13:20 -0800)
This patch fixes the warning reported by smatch.
 - wilc_deinit() warn: inconsistent returns 'sem:&hif_drv->sem_cfg_values'

This semaphore protect a cfg_values variable but cfg_values variables was not
used here. So, just remove this line.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index 6dd3076a78e176acd17ec58f521250814b2f6b7b..c8b4d86dc7b77ba20eaeb023dbd76695c9581647 100644 (file)
@@ -3940,8 +3940,6 @@ s32 wilc_deinit(struct host_if_drv *hif_drv)
                wilc_mq_destroy(&hif_msg_q);
        }
 
-       down(&hif_drv->sem_cfg_values);
-
        ret = remove_handler_in_list(hif_drv);
        if (ret)
                result = -ENOENT;