]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: comedi_test: ao subdevice does not support async commands
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 17 Apr 2014 17:07:50 +0000 (10:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Apr 2014 17:21:29 +0000 (10:21 -0700)
The comedi_subdevices array is kzalloc()'d so the async command callbacks do
not need to be set to NULL when the analog output subdevice is initialized.

Also, remove the initialzation of the subdevice 'len_chanlist' since this
value is only used by the async commands. The core will default it to 1.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/comedi_test.c

index cd9562556d2c8118f9c76a3b18cf1de65d9cee40..ad5014a4074e540f5e3a64b72144ad3f7871cfe9 100644 (file)
@@ -413,11 +413,7 @@ static int waveform_attach(struct comedi_device *dev,
        s->n_chan = N_CHANS;
        s->maxdata = 0xffff;
        s->range_table = &waveform_ai_ranges;
-       s->len_chanlist = s->n_chan * 2;
        s->insn_write = waveform_ao_insn_write;
-       s->do_cmd = NULL;
-       s->do_cmdtest = NULL;
-       s->cancel = NULL;
 
        /* Our default loopback value is just a 0V flatline */
        for (i = 0; i < s->n_chan; i++)