]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: comedi: multiq3: use comedi_request_region()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 9 Apr 2013 23:29:13 +0000 (16:29 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Apr 2013 19:47:53 +0000 (12:47 -0700)
Use comedi_request_region() to request the I/O region used by this
driver.

Remove the noise when the board is first attached as well as the
error message when the request_region() fails, comedi_request_reqion()
will output the error message if necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/multiq3.c

index 475020652e4e814a99407073f6d782014e5bad74..b6bc2dabbcc77e826e9178ae7715ed457fcc535b 100644 (file)
@@ -226,22 +226,16 @@ static int multiq3_attach(struct comedi_device *dev,
                          struct comedi_devconfig *it)
 {
        struct multiq3_private *devpriv;
-       int result = 0;
-       unsigned long iobase;
        struct comedi_subdevice *s;
+       int ret;
 
-       iobase = it->options[0];
-       printk(KERN_INFO "comedi%d: multiq3: 0x%04lx ", dev->minor, iobase);
-       if (!request_region(iobase, MULTIQ3_SIZE, "multiq3")) {
-               printk(KERN_ERR "comedi%d: I/O port conflict\n", dev->minor);
-               return -EIO;
-       }
-
-       dev->iobase = iobase;
+       ret = comedi_request_region(dev, it->options[0], MULTIQ3_SIZE);
+       if (ret)
+               return ret;
 
-       result = comedi_alloc_subdevices(dev, 5);
-       if (result)
-               return result;
+       ret = comedi_alloc_subdevices(dev, 5);
+       if (ret)
+               return ret;
 
        devpriv = kzalloc(sizeof(*devpriv), GFP_KERNEL);
        if (!devpriv)