]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
sched: Optimize branch hint in context_switch()
authorTim Blechmann <tim@klingt.org>
Tue, 24 Nov 2009 10:55:27 +0000 (11:55 +0100)
committerIngo Molnar <mingo@elte.hu>
Tue, 24 Nov 2009 11:18:42 +0000 (12:18 +0100)
Branch hint profiling on my nehalem machine showed over 90%
incorrect branch hints:

  10420275 170645395  94 context_switch                 sched.c
   3043
  10408421 171098521  94 context_switch                 sched.c
   3050

Signed-off-by: Tim Blechmann <tim@klingt.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <4B0BBB9F.6080304@klingt.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c

index 93474a7935ae482aaa4fdd2d99f37a2830b00fe1..010d5e16b4c5efe56976d01c1190f2deb25f5f3a 100644 (file)
@@ -2829,14 +2829,14 @@ context_switch(struct rq *rq, struct task_struct *prev,
         */
        arch_start_context_switch(prev);
 
-       if (unlikely(!mm)) {
+       if (likely(!mm)) {
                next->active_mm = oldmm;
                atomic_inc(&oldmm->mm_count);
                enter_lazy_tlb(oldmm, next);
        } else
                switch_mm(oldmm, mm, next);
 
-       if (unlikely(!prev->mm)) {
+       if (likely(!prev->mm)) {
                prev->active_mm = NULL;
                rq->prev_mm = oldmm;
        }