]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hwmon: (ad7314) Convert to use devm_ functions
authorGuenter Roeck <linux@roeck-us.net>
Sat, 2 Jun 2012 16:57:57 +0000 (09:57 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 12 Sep 2012 13:42:56 +0000 (06:42 -0700)
Convert to use devm_ functions to reduce code size and simplify the code.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ad7314.c

index cfec802cf9ca949b705d24a1d862a702af223193..455294f89eac3815a9f53d3e74cb775ff52e8123 100644 (file)
@@ -104,16 +104,16 @@ static int __devinit ad7314_probe(struct spi_device *spi_dev)
        int ret;
        struct ad7314_data *chip;
 
-       chip = kzalloc(sizeof(*chip), GFP_KERNEL);
-       if (chip == NULL) {
-               ret = -ENOMEM;
-               goto error_ret;
-       }
+       chip = devm_kzalloc(&spi_dev->dev, sizeof(*chip), GFP_KERNEL);
+       if (chip == NULL)
+               return -ENOMEM;
+
        dev_set_drvdata(&spi_dev->dev, chip);
 
        ret = sysfs_create_group(&spi_dev->dev.kobj, &ad7314_group);
        if (ret < 0)
-               goto error_free_chip;
+               return ret;
+
        chip->hwmon_dev = hwmon_device_register(&spi_dev->dev);
        if (IS_ERR(chip->hwmon_dev)) {
                ret = PTR_ERR(chip->hwmon_dev);
@@ -124,9 +124,6 @@ static int __devinit ad7314_probe(struct spi_device *spi_dev)
        return 0;
 error_remove_group:
        sysfs_remove_group(&spi_dev->dev.kobj, &ad7314_group);
-error_free_chip:
-       kfree(chip);
-error_ret:
        return ret;
 }
 
@@ -136,7 +133,6 @@ static int __devexit ad7314_remove(struct spi_device *spi_dev)
 
        hwmon_device_unregister(chip->hwmon_dev);
        sysfs_remove_group(&spi_dev->dev.kobj, &ad7314_group);
-       kfree(chip);
 
        return 0;
 }