]> git.karo-electronics.de Git - linux-beck.git/commitdiff
lpfc: remove incorrect lockdep assertion
authorSebastian Herbszt <herbszt@gmx.de>
Sun, 17 Apr 2016 11:27:27 +0000 (13:27 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 26 Apr 2016 02:06:49 +0000 (22:06 -0400)
Remove incorrect lockdep assertion from lpfc_sli_hbqbuf_find() which
acquires the hbalock itself. Fix the comment which resulted in this
mistake.

Fixes: 1c2ba475eb0e ("lpfc: Add lockdep assertions")
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_sli.c

index 6b267b67f845a78b69306d2c54f54762989c90bc..70edf21ae1b944124093933e3378581ac32f7ca6 100644 (file)
@@ -2000,10 +2000,9 @@ lpfc_sli_hbqbuf_get(struct list_head *rb_list)
  * @phba: Pointer to HBA context object.
  * @tag: Tag of the hbq buffer.
  *
- * This function is called with hbalock held. This function searches
- * for the hbq buffer associated with the given tag in the hbq buffer
- * list. If it finds the hbq buffer, it returns the hbq_buffer other wise
- * it returns NULL.
+ * This function searches for the hbq buffer associated with the given tag in
+ * the hbq buffer list. If it finds the hbq buffer, it returns the hbq_buffer
+ * otherwise it returns NULL.
  **/
 static struct hbq_dmabuf *
 lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag)
@@ -2012,8 +2011,6 @@ lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag)
        struct hbq_dmabuf *hbq_buf;
        uint32_t hbqno;
 
-       lockdep_assert_held(&phba->hbalock);
-
        hbqno = tag >> 16;
        if (hbqno >= LPFC_MAX_HBQS)
                return NULL;