]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ipv6: Add GSO support on forwarding path
authorHerbert Xu <herbert@gondor.apana.org.au>
Thu, 27 May 2010 23:14:30 +0000 (16:14 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 7 Nov 2011 20:31:51 +0000 (12:31 -0800)
commit 0aa68271510ae2b221d4b60892103837be63afe4 upstream.

Currently we disallow GSO packets on the IPv6 forward path.
This patch fixes this.

Note that I discovered that our existing GSO MTU checks (e.g.,
IPv4 forwarding) are buggy in that they skip the check altogether,
when they really should be checking gso_size + header instead.

I have also been lazy here in that I haven't bothered to segment
the GSO packet by hand before generating an ICMP message.  Someone
should add that to be 100% correct.

Reported-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Apollon Oikonomopoulos <apoikos@gmail.com>
Signed-off-by: Faidon Liambotis <paravoid@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv6/ip6_output.c

index eca3ef77f22760fa4bb0a0fbb05ec293b0409005..9ad57923440f4dee631eb14b9e502c03858aa551 100644 (file)
@@ -510,7 +510,7 @@ int ip6_forward(struct sk_buff *skb)
                }
        }
 
-       if (skb->len > dst_mtu(dst)) {
+       if (skb->len > dst_mtu(dst) && !skb_is_gso(skb)) {
                /* Again, force OUTPUT device used as source address */
                skb->dev = dst->dev;
                icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, dst_mtu(dst), skb->dev);