]> git.karo-electronics.de Git - linux-beck.git/commitdiff
phy: helpers for USB ULPI PHY registering
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Wed, 13 May 2015 12:26:52 +0000 (15:26 +0300)
committerFelipe Balbi <balbi@ti.com>
Wed, 13 May 2015 17:06:56 +0000 (12:06 -0500)
ULPI PHYs need to be bound to their controllers with a
lookup. This adds helpers that the ULPI drivers can use to
do both, the registration of the PHY and the lookup, at the
same time.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/phy/ulpi_phy.h [new file with mode: 0644]

diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h
new file mode 100644 (file)
index 0000000..ac49fb6
--- /dev/null
@@ -0,0 +1,31 @@
+#include <linux/phy/phy.h>
+
+/**
+ * Helper that registers PHY for a ULPI device and adds a lookup for binding it
+ * and it's controller, which is always the parent.
+ */
+static inline struct phy
+*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops)
+{
+       struct phy *phy;
+       int ret;
+
+       phy = phy_create(&ulpi->dev, NULL, ops);
+       if (IS_ERR(phy))
+               return phy;
+
+       ret = phy_create_lookup(phy, "usb2-phy", dev_name(ulpi->dev.parent));
+       if (ret) {
+               phy_destroy(phy);
+               return ERR_PTR(ret);
+       }
+
+       return phy;
+}
+
+/* Remove a PHY that was created with ulpi_phy_create() and it's lookup. */
+static inline void ulpi_phy_destroy(struct ulpi *ulpi, struct phy *phy)
+{
+       phy_remove_lookup(phy, "usb2-phy", dev_name(ulpi->dev.parent));
+       phy_destroy(phy);
+}