]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
usb: host: fsl-mph-dr-of: use of_property_read_bool
authorJulia Lawall <julia.lawall@lip6.fr>
Fri, 5 Aug 2016 11:26:53 +0000 (13:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Aug 2016 13:49:01 +0000 (15:49 +0200)
Use of_property_read_bool to check for the existence of a property.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,x;
@@
- if (of_get_property(e1,e2,NULL))
- x = true;
- else
- x = false;
+ x = of_property_read_bool(e1,e2);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/fsl-mph-dr-of.c

index 1044b0f9d656f122f4bf3a994465147683f9b05f..f07ccb25bc244f4f98c33a80d12a9c874e3696c1 100644 (file)
@@ -222,23 +222,17 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
        pdata->controller_ver = usb_get_ver_info(np);
 
        /* Activate Erratum by reading property in device tree */
-       if (of_get_property(np, "fsl,usb-erratum-a007792", NULL))
-               pdata->has_fsl_erratum_a007792 = 1;
-       else
-               pdata->has_fsl_erratum_a007792 = 0;
-       if (of_get_property(np, "fsl,usb-erratum-a005275", NULL))
-               pdata->has_fsl_erratum_a005275 = 1;
-       else
-               pdata->has_fsl_erratum_a005275 = 0;
+       pdata->has_fsl_erratum_a007792 =
+               of_property_read_bool(np, "fsl,usb-erratum-a007792");
+       pdata->has_fsl_erratum_a005275 =
+               of_property_read_bool(np, "fsl,usb-erratum-a005275");
 
        /*
         * Determine whether phy_clk_valid needs to be checked
         * by reading property in device tree
         */
-       if (of_get_property(np, "phy-clk-valid", NULL))
-               pdata->check_phy_clk_valid = 1;
-       else
-               pdata->check_phy_clk_valid = 0;
+       pdata->check_phy_clk_valid =
+               of_property_read_bool(np, "phy-clk-valid");
 
        if (pdata->have_sysif_regs) {
                if (pdata->controller_ver == FSL_USB_VER_NONE) {