]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
[media] Staging: media: radio-bcm2048: remove incorrect __exit markups
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 1 Mar 2017 23:50:03 +0000 (20:50 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 22 Mar 2017 13:14:58 +0000 (10:14 -0300)
Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/bcm2048/radio-bcm2048.c

index ddf7b9dacb50fdb6cd6f4d55c258fad1a70d6847..375c6178032a10dbae492b1a90740293d35558d5 100644 (file)
@@ -2642,7 +2642,7 @@ exit:
        return err;
 }
 
-static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
+static int bcm2048_i2c_driver_remove(struct i2c_client *client)
 {
        struct bcm2048_device *bdev = i2c_get_clientdata(client);
 
@@ -2681,7 +2681,7 @@ static struct i2c_driver bcm2048_i2c_driver = {
                .name   = BCM2048_DRIVER_NAME,
        },
        .probe          = bcm2048_i2c_driver_probe,
-       .remove         = __exit_p(bcm2048_i2c_driver_remove),
+       .remove         = bcm2048_i2c_driver_remove,
        .id_table       = bcm2048_id,
 };