]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
md: raid5: chunk size check in setup_conf
authorraz ben yehuda <raziebe@gmail.com>
Tue, 16 Jun 2009 07:01:36 +0000 (17:01 +1000)
committerNeilBrown <neilb@suse.de>
Tue, 16 Jun 2009 07:01:36 +0000 (17:01 +1000)
have raid5 check chunk size in run/reshape method instead of in md

Signed-off-by: raziebe@gmail.com
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c

index 7fb97c65ad3757a3388b6c26ffaa0a35530727bf..be4e62f611bc51c3f955baa621d96bed95660a67 100644 (file)
@@ -4336,7 +4336,8 @@ static raid5_conf_t *setup_conf(mddev_t *mddev)
                return ERR_PTR(-EINVAL);
        }
 
-       if (!mddev->new_chunk || mddev->new_chunk % PAGE_SIZE) {
+       if (!mddev->new_chunk || mddev->new_chunk % PAGE_SIZE ||
+           !is_power_of_2(mddev->new_chunk)) {
                printk(KERN_ERR "raid5: invalid chunk size %d for %s\n",
                        mddev->new_chunk, mdname(mddev));
                return ERR_PTR(-EINVAL);