]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Smack: Assign smack_known_web as default smk_in label for kernel thread's socket
authorMarcin Lis <m.lis@samsung.com>
Thu, 22 Jan 2015 14:40:33 +0000 (15:40 +0100)
committerCasey Schaufler <casey@schaufler-ca.com>
Mon, 23 Mar 2015 20:19:37 +0000 (13:19 -0700)
This change fixes the bug associated with sockets owned by kernel threads. These
sockets, created usually by network devices' drivers tasks, received smk_in
label from the task that created them - the "floor" label in the most cases. The
result was that they were not able to receive data packets because of missing
smack rules. The main reason of the access deny is that the socket smk_in label
is placed as the object during smk check, kernel thread's capabilities are
omitted.

Signed-off-by: Marcin Lis <m.lis@samsung.com>
security/smack/smack_lsm.c

index c934311812f1a777093c44a89543dcae924b8568..a097dc7d4669236d12fb72aad43a46e2fbed6aba 100644 (file)
@@ -2452,7 +2452,21 @@ static int smack_inode_setsecurity(struct inode *inode, const char *name,
 static int smack_socket_post_create(struct socket *sock, int family,
                                    int type, int protocol, int kern)
 {
-       if (family != PF_INET || sock->sk == NULL)
+       struct socket_smack *ssp;
+
+       if (sock->sk == NULL)
+               return 0;
+
+       /*
+        * Sockets created by kernel threads receive web label.
+        */
+       if (unlikely(current->flags & PF_KTHREAD)) {
+               ssp = sock->sk->sk_security;
+               ssp->smk_in = &smack_known_web;
+               ssp->smk_out = &smack_known_web;
+       }
+
+       if (family != PF_INET)
                return 0;
        /*
         * Set the outbound netlbl.