]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ti-soc-thermal: Use devm_kcalloc() in ti_bandgap_build()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 26 Apr 2017 14:45:25 +0000 (16:45 +0200)
committerEduardo Valentin <edubezval@gmail.com>
Wed, 24 May 2017 03:06:56 +0000 (20:06 -0700)
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".

This issue was detected by using the Coccinelle software.

Acked-by: Keerthy <j-keerthy@ti.com>
Tested-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/ti-soc-thermal/ti-bandgap.c

index ba9c302454fb398490046be46831c0a0f821788c..f19cb7612a65942258731231c274c2e5aee41c64 100644 (file)
@@ -1224,8 +1224,8 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
                bgp->conf = of_id->data;
 
        /* register shadow for context save and restore */
-       bgp->regval = devm_kzalloc(&pdev->dev, sizeof(*bgp->regval) *
-                                  bgp->conf->sensor_count, GFP_KERNEL);
+       bgp->regval = devm_kcalloc(&pdev->dev, bgp->conf->sensor_count,
+                                  sizeof(*bgp->regval), GFP_KERNEL);
        if (!bgp->regval) {
                dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
                return ERR_PTR(-ENOMEM);