]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
net/mlx4_core: Make sure the max number of QPs per MCG isn't exceeded
authorAlexander Guller <alexg@mellanox.com>
Wed, 16 Jul 2014 08:57:49 +0000 (11:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Jul 2014 06:26:24 +0000 (23:26 -0700)
In B0 steering mode when adding QPs to the default MCG entry need
to check that maximal number of QPs per MCG entry was not exceeded.

Signed-off-by: Alexander Guller <alexg@mellanox.com>
Reviewed-by: Aviad Yehezkel <aviadye@mellanox.co.il>
Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/mcg.c

index 04a8636a0b7e6d2cb8a4c8ba9d8ceb78a8b95a97..39ab85a56c9a2f754a10d7c8d8ede8e1aabdc593 100644 (file)
@@ -477,8 +477,14 @@ static int add_promisc_qp(struct mlx4_dev *dev, u8 port,
        /* now need to add all the promisc qps to default entry */
        memset(mgm, 0, sizeof *mgm);
        members_count = 0;
-       list_for_each_entry(dqp, &s_steer->promisc_qps[steer], list)
+       list_for_each_entry(dqp, &s_steer->promisc_qps[steer], list) {
+               if (members_count == dev->caps.num_qp_per_mgm) {
+                       /* entry is full */
+                       err = -ENOMEM;
+                       goto out_list;
+               }
                mgm->qp[members_count++] = cpu_to_be32(dqp->qpn & MGM_QPN_MASK);
+       }
        mgm->members_count = cpu_to_be32(members_count | MLX4_PROT_ETH << 30);
 
        err = mlx4_WRITE_PROMISC(dev, port, steer, mailbox);