]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug()
authorJingoo Han <jg1.han@samsung.com>
Wed, 20 Feb 2013 02:15:49 +0000 (13:15 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 20 Feb 2013 05:53:30 +0000 (16:53 +1100)
Fix the checkpatch warning as below:

  WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-rs5c372.c

index 76f565ae384d623d78acffbdf9b124149df67efe..581739f40097320fda63db04fa044b29c114a702 100644 (file)
@@ -311,8 +311,7 @@ static int rs5c_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
                buf &= ~RS5C_CTRL1_AALE;
 
        if (i2c_smbus_write_byte_data(client, addr, buf) < 0) {
-               printk(KERN_WARNING "%s: can't update alarm\n",
-                       rs5c->rtc->name);
+               dev_warn(dev, "can't update alarm\n");
                status = -EIO;
        } else
                rs5c->regs[RS5C_REG_CTRL1] = buf;
@@ -381,7 +380,7 @@ static int rs5c_set_alarm(struct device *dev, struct rtc_wkalrm *t)
                addr = RS5C_ADDR(RS5C_REG_CTRL1);
                buf[0] = rs5c->regs[RS5C_REG_CTRL1] & ~RS5C_CTRL1_AALE;
                if (i2c_smbus_write_byte_data(client, addr, buf[0]) < 0) {
-                       pr_debug("%s: can't disable alarm\n", rs5c->rtc->name);
+                       dev_dbg(dev, "can't disable alarm\n");
                        return -EIO;
                }
                rs5c->regs[RS5C_REG_CTRL1] = buf[0];
@@ -395,7 +394,7 @@ static int rs5c_set_alarm(struct device *dev, struct rtc_wkalrm *t)
        for (i = 0; i < sizeof(buf); i++) {
                addr = RS5C_ADDR(RS5C_REG_ALARM_A_MIN + i);
                if (i2c_smbus_write_byte_data(client, addr, buf[i]) < 0) {
-                       pr_debug("%s: can't set alarm time\n", rs5c->rtc->name);
+                       dev_dbg(dev, "can't set alarm time\n");
                        return -EIO;
                }
        }
@@ -405,8 +404,7 @@ static int rs5c_set_alarm(struct device *dev, struct rtc_wkalrm *t)
                addr = RS5C_ADDR(RS5C_REG_CTRL1);
                buf[0] = rs5c->regs[RS5C_REG_CTRL1] | RS5C_CTRL1_AALE;
                if (i2c_smbus_write_byte_data(client, addr, buf[0]) < 0)
-                       printk(KERN_WARNING "%s: can't enable alarm\n",
-                               rs5c->rtc->name);
+                       dev_warn(dev, "can't enable alarm\n");
                rs5c->regs[RS5C_REG_CTRL1] = buf[0];
        }