]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
HID: hid-sensor-hub: change kmalloc + memcpy by kmemdup
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 14 Aug 2013 08:07:11 +0000 (11:07 +0300)
committerJiri Kosina <jkosina@suse.cz>
Wed, 4 Sep 2013 10:19:13 +0000 (12:19 +0200)
The patch substitutes kmemdup for kmalloc followed by memcpy.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-sensor-hub.c

index 1877a25524837e01839f6d3372cd45f4fce4622c..e46e0134b0f979b5a77c8576e77a819f98ee9108 100644 (file)
@@ -430,11 +430,10 @@ static int sensor_hub_raw_event(struct hid_device *hdev,
                if (pdata->pending.status && pdata->pending.attr_usage_id ==
                                report->field[i]->usage->hid) {
                        hid_dbg(hdev, "data was pending ...\n");
-                       pdata->pending.raw_data = kmalloc(sz, GFP_ATOMIC);
-                       if (pdata->pending.raw_data) {
-                               memcpy(pdata->pending.raw_data, ptr, sz);
+                       pdata->pending.raw_data = kmemdup(ptr, sz, GFP_ATOMIC);
+                       if (pdata->pending.raw_data)
                                pdata->pending.raw_size = sz;
-                       else
+                       else
                                pdata->pending.raw_size = 0;
                        complete(&pdata->pending.ready);
                }