]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: comedi: gsc_hpdi: usleep_range is preferred over udelay
authorIan Abbott <abbotti@mev.co.uk>
Tue, 5 May 2015 17:47:26 +0000 (18:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 May 2015 12:57:26 +0000 (14:57 +0200)
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt".  `udelay()` is only called once
from a place where sleeping is allowed.  Replace it with a call to
`usleep_range()` with a reasonable upper limit.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/gsc_hpdi.c

index 0e04f15feb389ea1658c970c3e18451da5f92de1..31ff108072603ad172bff935a017122a6099996a 100644 (file)
@@ -520,7 +520,7 @@ static int gsc_hpdi_init(struct comedi_device *dev)
 
        /* wait 10usec after reset before accessing fifos */
        writel(BOARD_RESET_BIT, dev->mmio + BOARD_CONTROL_REG);
-       udelay(10);
+       usleep_range(10, 1000);
 
        writel(ALMOST_EMPTY_BITS(32) | ALMOST_FULL_BITS(32),
               dev->mmio + RX_PROG_ALMOST_REG);