]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
acpi_power_meter: clean up code around setup_attrs
authorKyle McMartin <kyle@mcmartin.ca>
Mon, 2 Apr 2012 18:19:04 +0000 (14:19 -0400)
committerGuenter Roeck <guenter.roeck@ericsson.com>
Mon, 21 May 2012 02:41:49 +0000 (19:41 -0700)
We don't need to duplicate if (res) checks if we're always running
one or the other.

Signed-off-by: Kyle McMartin <kyle@redhat.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
drivers/hwmon/acpi_power_meter.c

index c3f3058a70994b01a7e1c1dfca0eb0ae80846cba..34ad5a27a7e9fcd68b7597f799a99387f421c835 100644 (file)
@@ -697,21 +697,20 @@ static int setup_attrs(struct acpi_power_meter_resource *resource)
                        goto skip_unsafe_cap;
                }
 
-               if (resource->caps.configurable_cap) {
+               if (resource->caps.configurable_cap)
                        res = register_attrs(resource, rw_cap_attrs);
-                       if (res)
-                               goto error;
-               } else {
+               else
                        res = register_attrs(resource, ro_cap_attrs);
-                       if (res)
-                               goto error;
-               }
+
+               if (res)
+                       goto error;
+
                res = register_attrs(resource, misc_cap_attrs);
                if (res)
                        goto error;
        }
-skip_unsafe_cap:
 
+skip_unsafe_cap:
        if (resource->caps.flags & POWER_METER_CAN_TRIP) {
                res = register_attrs(resource, trip_attrs);
                if (res)