]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ext4: optimize starting extent in ext4_ext_rm_leaf()
authorAshish Sangwan <a.sangwan@samsung.com>
Tue, 18 Jun 2013 15:28:45 +0000 (11:28 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 18 Jun 2013 15:28:45 +0000 (11:28 -0400)
Both hole punch and truncate use ext4_ext_rm_leaf() for removing
blocks.  Currently we choose the last extent as the starting
point for removing blocks:

ex = EXT_LAST_EXTENT(eh);

This is OK for truncate but for hole punch we can optimize the extent
selection as the path is already initialized.  We could use this
information to select proper starting extent.  The code change in this
patch will not affect truncate as for truncate path[depth].p_ext will
always be NULL.

Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/extents.c

index 937593e2f00685db06a20ce4827279b2116d7e3c..6935bbcc78e299322f1617a678c440659e2bf891 100644 (file)
@@ -2504,7 +2504,9 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inode,
                return -EIO;
        }
        /* find where to start removing */
-       ex = EXT_LAST_EXTENT(eh);
+       ex = path[depth].p_ext;
+       if (!ex)
+               ex = EXT_LAST_EXTENT(eh);
 
        ex_ee_block = le32_to_cpu(ex->ee_block);
        ex_ee_len = ext4_ext_get_actual_len(ex);