]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: bcm2835-audio: use | instead of || otherwise result is just boolean 1
authorColin Ian King <colin.king@canonical.com>
Wed, 1 Feb 2017 11:57:11 +0000 (11:57 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Feb 2017 12:05:06 +0000 (13:05 +0100)
The incorrect or operator is being used resulting in cookies being
set to 1 (true) rather than the intended hex value.  Fix this by
using | instead of ||.

Issue found with static analysis with cppcheck

Fixes: 0cec463e391e05b807a ("staging: bcm2835-audio: Simplify callback structure for write data")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/bcm2835-audio/bcm2835-vchiq.c

index 4bdc8d8eacb9a0cdbed53e12579c804e52c363e9..878aecfa61b8b8bc25e1c12aade2788c4a20548d 100644 (file)
@@ -91,9 +91,9 @@ bcm2835_vchi_msg_queue(VCHI_SERVICE_HANDLE_T handle,
                                         size);
 }
 
-static const u32 BCM2835_AUDIO_WRITE_COOKIE1 = ('B' << 24 | 'C' << 16 ||
+static const u32 BCM2835_AUDIO_WRITE_COOKIE1 = ('B' << 24 | 'C' << 16 |
                                                'M' << 8  | 'A');
-static const u32 BCM2835_AUDIO_WRITE_COOKIE2 = ('D' << 24 | 'A' << 16 ||
+static const u32 BCM2835_AUDIO_WRITE_COOKIE2 = ('D' << 24 | 'A' << 16 |
                                                'T' << 8  | 'A');
 
 struct bcm2835_audio_work {