]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
xhci: fix incorrect type in assignment in handle_device_notification()
authorXenia Ragiadakou <burzalodowa@gmail.com>
Mon, 9 Sep 2013 18:03:10 +0000 (21:03 +0300)
committerSarah Sharp <sarah.a.sharp@linux.intel.com>
Mon, 2 Dec 2013 20:59:44 +0000 (12:59 -0800)
This patch converts Event TRB's 3rd field, which has type le32, to CPU
byteorder before using it to retrieve the Slot ID with TRB_TO_SLOT_ID macro.
This bug was found using sparse.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
drivers/usb/host/xhci-ring.c

index 1e2f3f4958436fb120b81d41632ad7e7c76fb5b5..22da09388a74f4d46160d5f7eeacde97f45babf5 100644 (file)
@@ -1655,7 +1655,7 @@ static void handle_device_notification(struct xhci_hcd *xhci,
        u32 slot_id;
        struct usb_device *udev;
 
-       slot_id = TRB_TO_SLOT_ID(event->generic.field[3]);
+       slot_id = TRB_TO_SLOT_ID(le32_to_cpu(event->generic.field[3]));
        if (!xhci->devs[slot_id]) {
                xhci_warn(xhci, "Device Notification event for "
                                "unused slot %u\n", slot_id);