]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: addi_apci_2200: remove i_APCI2200_ConfigDigitalOutput()
authorH Hartley Sweeten <hartleys@visionengravers.com>
Tue, 6 Nov 2012 17:07:22 +0000 (10:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Nov 2012 19:21:38 +0000 (11:21 -0800)
The digital outputs of the board supported by this driver are not
configurable. This driver abuses the comedi API and uses the 'insn_config'
function of the digital output subdevice to enable/disable writing to
the eeprom on the board. Remove this function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi-data/hwdrv_apci2200.c
drivers/staging/comedi/drivers/addi_apci_2200.c

index 1396696a3050ac4072935a77be5b26c23e132348..9d4a117aad434651d6d1a73a535fb792a873271b 100644 (file)
@@ -75,42 +75,6 @@ static int apci2200_di_insn_bits(struct comedi_device *dev,
        return insn->n;
 }
 
-/*
-+----------------------------------------------------------------------------+
-| Function   Name   : int i_APCI2200_ConfigDigitalOutput (struct comedi_device *dev,
-|                    struct comedi_subdevice *s struct comedi_insn *insn,unsigned int *data)    |
-|                                                                                   |
-+----------------------------------------------------------------------------+
-| Task              : Configures The Digital Output Subdevice.               |
-+----------------------------------------------------------------------------+
-| Input Parameters  : struct comedi_device *dev : Driver handle                     |
-|                     unsigned int *data         : Data Pointer contains         |
-|                                          configuration parameters as below |
-|                      struct comedi_subdevice *s,   :pointer to subdevice structure
-|                       struct comedi_insn *insn      :pointer to insn structure                                                           |
-|                                        data[0]  :1:Memory on                          |
-|                                                  0:Memory off                         |
-|                                                                                                           |
-|                                                                                                                                       |
-+----------------------------------------------------------------------------+
-| Output Parameters :  --                                                                                                       |
-+----------------------------------------------------------------------------+
-| Return Value      : TRUE  : No error occur                                 |
-|                          : FALSE : Error occur. Return the error          |
-|                                                                               |
-+----------------------------------------------------------------------------+
-*/
-static int i_APCI2200_ConfigDigitalOutput(struct comedi_device *dev,
-                                         struct comedi_subdevice *s,
-                                         struct comedi_insn *insn,
-                                         unsigned int *data)
-{
-       struct addi_private *devpriv = dev->private;
-
-       devpriv->b_OutputMemoryStatus = data[0];
-       return insn->n;
-}
-
 static int apci2200_do_insn_bits(struct comedi_device *dev,
                                 struct comedi_subdevice *s,
                                 struct comedi_insn *insn,
index cf406595c73733074ed119c0f46d97dda0f16de4..69503b478455cb83206cf97f88ce9c821d975545 100644 (file)
@@ -22,7 +22,6 @@ static const struct addi_board apci2200_boardtypes[] = {
                .i_Timer                = 1,
                .reset                  = i_APCI2200_Reset,
                .di_bits                = apci2200_di_insn_bits,
-               .do_config              = i_APCI2200_ConfigDigitalOutput,
                .do_bits                = apci2200_do_insn_bits,
                .timer_config           = i_APCI2200_ConfigWatchdog,
                .timer_write            = i_APCI2200_StartStopWriteWatchdog,