]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
rtc: rtc-stk17ta8: use devm_rtc_device_register()
authorJingoo Han <jg1.han@samsung.com>
Wed, 20 Mar 2013 04:08:07 +0000 (15:08 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 20 Mar 2013 04:23:13 +0000 (15:23 +1100)
devm_rtc_device_register() is device managed and makes cleanup
paths simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-stk17ta8.c

index 7e4a6f65cb91433293d9b097a9323354fad1a263..af5e97e3f2724d0204d3f065f69061e1cf0447bd 100644 (file)
@@ -336,14 +336,13 @@ static int stk17ta8_rtc_probe(struct platform_device *pdev)
                }
        }
 
-       pdata->rtc = rtc_device_register(pdev->name, &pdev->dev,
+       pdata->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
                                  &stk17ta8_rtc_ops, THIS_MODULE);
        if (IS_ERR(pdata->rtc))
                return PTR_ERR(pdata->rtc);
 
        ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr);
-       if (ret)
-               rtc_device_unregister(pdata->rtc);
+
        return ret;
 }
 
@@ -352,7 +351,6 @@ static int stk17ta8_rtc_remove(struct platform_device *pdev)
        struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
 
        sysfs_remove_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr);
-       rtc_device_unregister(pdata->rtc);
        if (pdata->irq > 0)
                writeb(0, pdata->ioaddr + RTC_INTERRUPTS);
        return 0;