]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: unisys: visornic - check visorchannel_signalinsert/remove failures
authorTim Sell <Timothy.Sell@unisys.com>
Fri, 24 Jul 2015 16:00:23 +0000 (12:00 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jul 2015 20:43:37 +0000 (13:43 -0700)
Logic to check for failures of visorchannel_signalinsert() and
visorchannel_signalremove() were added, and a new sent_post_failed counter
tracks the number of times we failed to post a rcv buffer to the IO
partition.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c

index ec38b51eca010567f22987ebdcf2c8d3c6a479a9..a4aa8afd04dd57a05116ff6475fa298f302b677e 100644 (file)
@@ -102,6 +102,7 @@ struct chanstat {
        unsigned long sent_enbdis;
        unsigned long sent_promisc;
        unsigned long sent_post;
+       unsigned long sent_post_failed;
        unsigned long sent_xmit;
        unsigned long reject_count;
        unsigned long extra_rcvbufs_sent;
@@ -479,11 +480,14 @@ post_skb(struct uiscmdrsp *cmdrsp,
        if ((cmdrsp->net.rcvpost.frag.pi_off + skb->len) <= PI_PAGE_SIZE) {
                cmdrsp->net.type = NET_RCV_POST;
                cmdrsp->cmdtype = CMD_NET_TYPE;
-               visorchannel_signalinsert(devdata->dev->visorchannel,
+               if (visorchannel_signalinsert(devdata->dev->visorchannel,
                                          IOCHAN_TO_IOPART,
-                                         cmdrsp);
-               atomic_inc(&devdata->num_rcvbuf_in_iovm);
-               devdata->chstat.sent_post++;
+                                         cmdrsp)) {
+                       atomic_inc(&devdata->num_rcvbuf_in_iovm);
+                       devdata->chstat.sent_post++;
+               } else {
+                       devdata->chstat.sent_post_failed++;
+               }
        }
 }
 
@@ -505,10 +509,10 @@ send_enbdis(struct net_device *netdev, int state,
        devdata->cmdrsp_rcv->net.enbdis.context = netdev;
        devdata->cmdrsp_rcv->net.type = NET_RCV_ENBDIS;
        devdata->cmdrsp_rcv->cmdtype = CMD_NET_TYPE;
-       visorchannel_signalinsert(devdata->dev->visorchannel,
+       if (visorchannel_signalinsert(devdata->dev->visorchannel,
                                  IOCHAN_TO_IOPART,
-                                 devdata->cmdrsp_rcv);
-       devdata->chstat.sent_enbdis++;
+                                 devdata->cmdrsp_rcv))
+               devdata->chstat.sent_enbdis++;
 }
 
 /**
@@ -1501,6 +1505,9 @@ static ssize_t info_debugfs_read(struct file *file, char __user *buf,
                str_pos += scnprintf(vbuf + str_pos, len - str_pos,
                                     " chstat.sent_post = %lu\n",
                                     devdata->chstat.sent_post);
+               str_pos += scnprintf(vbuf + str_pos, len - str_pos,
+                                    " chstat.sent_post_failed = %lu\n",
+                                    devdata->chstat.sent_post_failed);
                str_pos += scnprintf(vbuf + str_pos, len - str_pos,
                                     " chstat.sent_xmit = %lu\n",
                                     devdata->chstat.sent_xmit);