]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ppdev: use pr_* macros
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Thu, 10 Nov 2016 22:12:01 +0000 (22:12 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Nov 2016 19:25:34 +0000 (20:25 +0100)
The coding style recommends not to use printk. Use pr_* macros.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/ppdev.c

index f08f3ed98e013c5c7402d2cbe455cf4176589d07..85c63e49df7ffeec905280ab009301490c92c749 100644 (file)
@@ -294,7 +294,7 @@ static int register_device(int minor, struct pp_struct *pp)
 
        port = parport_find_number(minor);
        if (!port) {
-               printk(KERN_WARNING "%s: no associated port!\n", name);
+               pr_warn("%s: no associated port!\n", name);
                kfree(name);
                return -ENXIO;
        }
@@ -308,7 +308,7 @@ static int register_device(int minor, struct pp_struct *pp)
        kfree(name);
 
        if (!pdev) {
-               printk(KERN_WARNING "%s: failed to register device!\n", name);
+               pr_warn("%s: failed to register device!\n", name);
                return -ENXIO;
        }
 
@@ -822,8 +822,7 @@ static int __init ppdev_init(void)
        int err = 0;
 
        if (register_chrdev(PP_MAJOR, CHRDEV, &pp_fops)) {
-               printk(KERN_WARNING CHRDEV ": unable to get major %d\n",
-                      PP_MAJOR);
+               pr_warn(CHRDEV ": unable to get major %d\n", PP_MAJOR);
                return -EIO;
        }
        ppdev_class = class_create(THIS_MODULE, CHRDEV);
@@ -833,11 +832,11 @@ static int __init ppdev_init(void)
        }
        err = parport_register_driver(&pp_driver);
        if (err < 0) {
-               printk(KERN_WARNING CHRDEV ": unable to register with parport\n");
+               pr_warn(CHRDEV ": unable to register with parport\n");
                goto out_class;
        }
 
-       printk(KERN_INFO PP_VERSION "\n");
+       pr_info(PP_VERSION "\n");
        goto out;
 
 out_class: