]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
qed: fix missing break in OOO_LB_TC case
authorColin Ian King <colin.king@canonical.com>
Wed, 5 Apr 2017 12:35:44 +0000 (13:35 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Apr 2017 20:20:26 +0000 (13:20 -0700)
There seems to be a missing break on the OOO_LB_TC case, pq_id
is being assigned and then re-assigned on the fall through default
case and that seems suspect.

Detected by CoverityScan, CID#1424402 ("Missing break in switch")

Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_ll2.c

index 708c601e8ccf8674084979f879a0fa4f8c76cc23..13e65d446ab3fa62fc4a9ff137344cf03c71b482 100644 (file)
@@ -1132,6 +1132,7 @@ static int qed_sp_ll2_tx_queue_start(struct qed_hwfn *p_hwfn,
                break;
        case OOO_LB_TC:
                pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OOO);
+               break;
        default:
                pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OFLD);
                break;