]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
rcu: Fix dubious "if" condition in __call_rcu_nocb_enqueue()
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Sun, 18 Aug 2013 19:21:57 +0000 (12:21 -0700)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Mon, 23 Sep 2013 16:13:44 +0000 (09:13 -0700)
This commit replaces an incorrect (but fortunately functional)
bitwise OR ("|") operator with the correct logical OR ("||").

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
kernel/rcutree_plugin.h

index 130c97b027f2e1f244cf2c23edfca913238e6dfa..6f9aecef8ab637a5432bbe24ec11ce7458dd8d8f 100644 (file)
@@ -2108,7 +2108,7 @@ static void __call_rcu_nocb_enqueue(struct rcu_data *rdp,
 
        /* If we are not being polled and there is a kthread, awaken it ... */
        t = ACCESS_ONCE(rdp->nocb_kthread);
-       if (rcu_nocb_poll | !t)
+       if (rcu_nocb_poll || !t)
                return;
        len = atomic_long_read(&rdp->nocb_q_count);
        if (old_rhpp == &rdp->nocb_head) {