]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
tty: serial: 8250: Merge duplicate conditions
authorAnton Wuerfel <anton.wuerfel@fau.de>
Thu, 14 Jan 2016 15:08:22 +0000 (16:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 7 Feb 2016 07:15:53 +0000 (23:15 -0800)
This patch refactors a switch case statement by merging an if condition
in the default case into an identical condition right after the switch
statement.
This comes with a slight change in behaviour: If pci_netmos_9900_numports
returns 0, an additional warning is printed.

Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@i4.cs.fau.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_pci.c

index ec8a63573fd227563ce6d97f6fe1827e0d0a8a57..4b1c241e6f7510936743b00aeb0f977f9a6cc406 100644 (file)
@@ -850,13 +850,13 @@ static int pci_netmos_init(struct pci_dev *dev)
                        break;
 
                default:
-                       if (num_serial == 0 ) {
-                               moan_device("unknown NetMos/Mostech device", dev);
-                       }
+                       break;
        }
 
-       if (num_serial == 0)
+       if (num_serial == 0) {
+               moan_device("unknown NetMos/Mostech device", dev);
                return -ENODEV;
+       }
 
        return num_serial;
 }