]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
cpufreq / sched: ignore SMT when determining max cpu capacity
authorSteve Muckle <steve.muckle@linaro.org>
Fri, 26 Aug 2016 18:40:47 +0000 (11:40 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 31 Aug 2016 22:32:57 +0000 (00:32 +0200)
PELT does not consider SMT when scaling its utilization values via
arch_scale_cpu_capacity(). The value in rq->cpu_capacity_orig does
take SMT into consideration though and therefore may be smaller than
the utilization reported by PELT.

On an Intel i7-3630QM for example rq->cpu_capacity_orig is 589 but
util_avg scales up to 1024. This means that a 50% utilized CPU will show
up in schedutil as ~86% busy.

Fix this by using the same CPU scaling value in schedutil as that which
is used by PELT.

Signed-off-by: Steve Muckle <smuckle@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/sched/cpufreq_schedutil.c

index 60d985f4dc47ee960ac18526da5c70f7f1b4b249..cb8a77b1ef1b1f474755508d974ae20b60577b8a 100644 (file)
@@ -147,7 +147,9 @@ static unsigned int get_next_freq(struct sugov_cpu *sg_cpu, unsigned long util,
 static void sugov_get_util(unsigned long *util, unsigned long *max)
 {
        struct rq *rq = this_rq();
-       unsigned long cfs_max = rq->cpu_capacity_orig;
+       unsigned long cfs_max;
+
+       cfs_max = arch_scale_cpu_capacity(NULL, smp_processor_id());
 
        *util = min(rq->cfs.avg.util_avg, cfs_max);
        *max = cfs_max;