]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: das16: clarify 8254 timer programming
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 29 Apr 2014 19:59:59 +0000 (12:59 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 May 2014 00:06:35 +0000 (20:06 -0400)
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/das16.c

index eb774c3ef17f45ed490b786c7a5e84e183b46021..a18c6b696ecf1aabc359642ed9d311fe5dc844ef 100644 (file)
@@ -740,9 +740,10 @@ static unsigned int das16_set_pacer(struct comedi_device *dev, unsigned int ns,
                                  &devpriv->divisor1, &devpriv->divisor2,
                                  &ns, rounding_flags);
 
-       /* Write the values of ctr1 and ctr2 into counters 1 and 2 */
-       i8254_load(timer_base, 0, 1, devpriv->divisor1, 2);
-       i8254_load(timer_base, 0, 2, devpriv->divisor2, 2);
+       i8254_set_mode(timer_base, 0, 1, I8254_MODE2 | I8254_BINARY);
+       i8254_set_mode(timer_base, 0, 2, I8254_MODE2 | I8254_BINARY);
+       i8254_write(timer_base, 0, 1, devpriv->divisor1);
+       i8254_write(timer_base, 0, 2, devpriv->divisor2);
 
        return ns;
 }