batman-adv: Place kref_get for neigh_node near use

It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 5e99a6e296e6267b2e24729585bb9c72ea304d0e..0792de869f4ecfb0b5a650f158de32d32ed8a6a4 100644 (file)
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -654,8 +654,8 @@ batadv_neigh_node_create(struct batadv_orig_node *orig_node,
 
        /* extra reference for return */
        kref_init(&neigh_node->refcount);
-       kref_get(&neigh_node->refcount);
 
+       kref_get(&neigh_node->refcount);
        hlist_add_head_rcu(&neigh_node->list, &orig_node->neigh_list);
 
        batadv_dbg(BATADV_DBG_BATMAN, orig_node->bat_priv,