]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
jz4740-battery: Check if platform_data is supplied
authorLars-Peter Clausen <lars@metafoo.de>
Thu, 11 Nov 2010 18:00:53 +0000 (19:00 +0100)
committerAnton Vorontsov <cbouatmailru@gmail.com>
Thu, 18 Nov 2010 13:56:22 +0000 (16:56 +0300)
Currently platform_data is dereferenced without checking whether it
is actually set, which can lead to kernel crashes.
This patch adds a check which will abort the drivers probe function
gracefully if no platform_data is supplied.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
drivers/power/jz4740-battery.c

index 2bbe04ae13a7cc6a0f518e33bee03fcb9b24dd92..5b4821593201047cd3791ba2adabec4a8bd7bd8a 100644 (file)
@@ -246,6 +246,11 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
        struct jz_battery *jz_battery;
        struct power_supply *battery;
 
+       if (!pdata) {
+               dev_err(&pdev->dev, "No platform_data supplied\n");
+               return -ENXIO;
+       }
+
        jz_battery = kzalloc(sizeof(*jz_battery), GFP_KERNEL);
        if (!jz_battery) {
                dev_err(&pdev->dev, "Failed to allocate driver structure\n");