staging: unisys: visorbus: move toolaction functions to remove prototypes

The toolchain functions show and store needed to be moved so the prototypes
were no longer needed.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 7dcf0b3a1017c9b472974e25f54821d72e3453c6..568ff9ea0bc344466c8e134044c19aacae5602ea 100644 (file)
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -185,10 +185,37 @@ static dev_t major_dev = -1; /*< indicates major num for device */
 
 /* prototypes for attributes */
 static ssize_t toolaction_show(struct device *dev,
-                              struct device_attribute *attr, char *buf);
+                              struct device_attribute *attr,
+                              char *buf)
+{
+       u8 tool_action = 0;
+
+       visorchannel_read(controlvm_channel,
+                         offsetof(struct spar_controlvm_channel_protocol,
+                                  tool_action), &tool_action, sizeof(u8));
+       return scnprintf(buf, PAGE_SIZE, "%u\n", tool_action);
+}
+
 static ssize_t toolaction_store(struct device *dev,
                                struct device_attribute *attr,
-                               const char *buf, size_t count);
+                               const char *buf, size_t count)
+{
+       u8 tool_action;
+       int ret;
+
+       if (kstrtou8(buf, 10, &tool_action))
+               return -EINVAL;
+
+       ret = visorchannel_write
+               (controlvm_channel,
+                offsetof(struct spar_controlvm_channel_protocol,
+                         tool_action),
+                &tool_action, sizeof(u8));
+
+       if (ret)
+               return ret;
+       return count;
+}
 static DEVICE_ATTR_RW(toolaction);
 
 static ssize_t boottotool_show(struct device *dev,
@@ -431,39 +458,6 @@ parser_string_get(struct parser_context *ctx)
        return value;
 }
 
-static ssize_t toolaction_show(struct device *dev,
-                              struct device_attribute *attr,
-                              char *buf)
-{
-       u8 tool_action = 0;
-
-       visorchannel_read(controlvm_channel,
-                         offsetof(struct spar_controlvm_channel_protocol,
-                                  tool_action), &tool_action, sizeof(u8));
-       return scnprintf(buf, PAGE_SIZE, "%u\n", tool_action);
-}
-
-static ssize_t toolaction_store(struct device *dev,
-                               struct device_attribute *attr,
-                               const char *buf, size_t count)
-{
-       u8 tool_action;
-       int ret;
-
-       if (kstrtou8(buf, 10, &tool_action))
-               return -EINVAL;
-
-       ret = visorchannel_write
-               (controlvm_channel,
-                offsetof(struct spar_controlvm_channel_protocol,
-                         tool_action),
-                &tool_action, sizeof(u8));
-
-       if (ret)
-               return ret;
-       return count;
-}
-
 static ssize_t boottotool_show(struct device *dev,
                               struct device_attribute *attr,
                               char *buf)