]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: das08: remove use of comedi_error()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 17 Jul 2014 18:57:44 +0000 (11:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jul 2014 00:59:02 +0000 (17:59 -0700)
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.

Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/das08.c

index 6e55ba5787b7ccf6bdccf3ffbb3a64013cc54fc5..fcf916a80c8d6d92b5099cc6a4254c72eac7c65c 100644 (file)
@@ -273,7 +273,7 @@ static int das08_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
                        else
                                data[n] = (1 << 15) - (lsb | (msb & 0x7f) << 8);
                } else {
-                       comedi_error(dev, "bug! unknown ai encoding");
+                       dev_err(dev->class_dev, "bug! unknown ai encoding\n");
                        return -1;
                }
        }