greybus: svc: Pass the correct pointer to input_free_device()

In gb_svc_input_create() fn, on failure, wrong pointer
was being passed to input_free_device(). Correct it.

svc->input gets initialized only on successful return of this fn,
so it is absolutely wrong to pass svc->input to input_free_device().

Testing Done: Tested on EVT2.0 platform.

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c
index e316f08ab7569a2fc744d4d3fe388fc87d75382d..48d07a91f01fe8e16374c64c4fb346f3d2b7e01b 100644 (file)
--- a/drivers/staging/greybus/svc.c
+++ b/drivers/staging/greybus/svc.c
@@ -1352,7 +1352,7 @@ static struct input_dev *gb_svc_input_create(struct gb_svc *svc)
        return input_dev;
 
 err_free_input:
-       input_free_device(svc->input);
+       input_free_device(input_dev);
        return ERR_PTR(-ENOMEM);
 }