]> git.karo-electronics.de Git - linux-beck.git/commitdiff
Input: synaptics-rmi4 - do not check for NULL when calling of_node_put()
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 25 Jul 2016 18:29:59 +0000 (11:29 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 26 Jul 2016 19:09:55 +0000 (12:09 -0700)
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_bus.c

index 253df96be4276cc9196a6c0ab25b04f838d061ac..a73580654c6b0cd3fd8faaeda2322bf88fdcd1ed 100644 (file)
@@ -232,10 +232,7 @@ err_put_device:
 void rmi_unregister_function(struct rmi_function *fn)
 {
        device_del(&fn->dev);
-
-       if (fn->dev.of_node)
-               of_node_put(fn->dev.of_node);
-
+       of_node_put(fn->dev.of_node);
        put_device(&fn->dev);
 }