]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
b44: Fix wedge when using netconsole.
authorDavid S. Miller <davem@davemloft.net>
Mon, 30 Nov 2009 08:13:28 +0000 (00:13 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 18 Dec 2009 21:43:53 +0000 (13:43 -0800)
[ Upstream commit 0cae200eec6330cd2c20b24279597be1da50dc93 ]

Fixes kernel bugzilla #14691

Due to the way netpoll works, it is perfectly legal to see
NAPI already scheduled when new device events are pending
in b44_interrupt().

So logging a message about it is wrong and in fact harmful.

Based upon a patch by Andreas Mohr.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/b44.c

index 24a79f463ff6192ddb8c3e962e55145b63cc05ef..351a258dccd660f36d0c69051d65e22e3069b81c 100644 (file)
@@ -913,9 +913,6 @@ static irqreturn_t b44_interrupt(int irq, void *dev_id)
                        bp->istat = istat;
                        __b44_disable_ints(bp);
                        __napi_schedule(&bp->napi);
-               } else {
-                       printk(KERN_ERR PFX "%s: Error, poll already scheduled\n",
-                              dev->name);
                }
 
 irq_ack: