]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
USB: isp1760: Fix endianness-sensitivity in of_isp1760_probe()
authorDave Martin <dave.martin@linaro.org>
Fri, 2 Dec 2011 16:58:18 +0000 (16:58 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 10 Dec 2011 00:18:18 +0000 (16:18 -0800)
Data read direct from device tree properties will be in the device
tree's native endianness (i.e., big-endian).

This patch uses of_property_read_u32() to read the bus-width
property in host byte order instead.

Signed-off-by: Dave Martin <dave.martin@linaro.org>
Acked-by: Pawel Moll <pawel.moll@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/isp1760-if.c

index a7dc1e1d45f2a77e1cfce4de339b449b8863f778..b605224fb9e32d0aa3927af4b036dcf08b2ac4ee 100644 (file)
@@ -47,9 +47,9 @@ static int of_isp1760_probe(struct platform_device *dev)
        int virq;
        resource_size_t res_len;
        int ret;
-       const unsigned int *prop;
        unsigned int devflags = 0;
        enum of_gpio_flags gpio_flags;
+       u32 bus_width = 0;
 
        drvdata = kzalloc(sizeof(*drvdata), GFP_KERNEL);
        if (!drvdata)
@@ -77,8 +77,8 @@ static int of_isp1760_probe(struct platform_device *dev)
                devflags |= ISP1760_FLAG_ISP1761;
 
        /* Some systems wire up only 16 of the 32 data lines */
-       prop = of_get_property(dp, "bus-width", NULL);
-       if (prop && *prop == 16)
+       of_property_read_u32(dp, "bus-width", &bus_width);
+       if (bus_width == 16)
                devflags |= ISP1760_FLAG_BUS_WIDTH_16;
 
        if (of_get_property(dp, "port1-otg", NULL) != NULL)