]> git.karo-electronics.de Git - linux-beck.git/commitdiff
mwifiex: do not short circuit exit from mwifiex_set_mgmt_ies
authorJohn Linville <linville@tuxdriver.com>
Tue, 23 Jun 2015 19:04:03 +0000 (15:04 -0400)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 21 Jul 2015 13:46:49 +0000 (16:46 +0300)
Without this change, the code simply exits after calling
mwifiex_uap_set_head_tail_ies, leving the call to
mwifiex_set_mgmt_beacon_data_ies as dead code.

Coverity CID #1271292

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/mwifiex/ie.c

index 0ba8945094139c5e02374a11034e66777186c074..23e368c77c08bd22a37a262f47e1ad82ae07ba97 100644 (file)
@@ -409,6 +409,8 @@ int mwifiex_set_mgmt_ies(struct mwifiex_private *priv,
        int ret;
 
        ret = mwifiex_uap_parse_tail_ies(priv, info);
+
+       if (ret)
                return ret;
 
        return mwifiex_set_mgmt_beacon_data_ies(priv, info);