]> git.karo-electronics.de Git - linux-beck.git/commitdiff
iio: sx9500: Use complete() instead of complete_all()
authorDaniel Wagner <daniel.wagner@bmw-carit.de>
Thu, 4 Aug 2016 13:07:10 +0000 (15:07 +0200)
committerJonathan Cameron <jic23@kernel.org>
Mon, 15 Aug 2016 17:01:27 +0000 (18:01 +0100)
There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

waiter context                          waker context

sx9500_read_proximity()
  sx9500_inc_chan_users()
  sx9500_inc_data_rdy_users()
  wait_for_completion_interruptible()

                                        s9500_irq_thread_handler()
                                          complete()

  reinit_completion()

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/proximity/sx9500.c

index 1d74b3aafeedbcc7a7c44dc8abd8505424b17932..6f84f53dfe541550af8fef6b5c1d804f27709aa3 100644 (file)
@@ -516,7 +516,7 @@ static irqreturn_t sx9500_irq_thread_handler(int irq, void *private)
                sx9500_push_events(indio_dev);
 
        if (val & SX9500_CONVDONE_IRQ)
-               complete_all(&data->completion);
+               complete(&data->completion);
 
 out:
        mutex_unlock(&data->mutex);