]> git.karo-electronics.de Git - linux-beck.git/commitdiff
ASoC: lm49453: Remove unnecessary suspend/resume bias level changes
authorLars-Peter Clausen <lars@metafoo.de>
Tue, 2 Sep 2014 20:20:31 +0000 (22:20 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 3 Sep 2014 18:26:26 +0000 (19:26 +0100)
The ASoC core will only call the suspend/resume callbacks when the device's
DAPM context is idle. Since this driver sets idle_bias_off to true this
means that the device is already in SND_SOC_BIAS_OFF when the suspend
callback is called, so there is no need to manually set this state again.
There is also no need to go to SND_SOC_BIAS_STANDBY in the resume callback
since the core will go right back to SND_SOC_BIAS_OFF.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/lm49453.c

index 275b3f72f3f42db71bd94b7ca2b35f146b134d8a..c1ae5764983fa73fd86f67c360d15876c284477c 100644 (file)
@@ -1395,18 +1395,6 @@ static struct snd_soc_dai_driver lm49453_dai[] = {
        },
 };
 
-static int lm49453_suspend(struct snd_soc_codec *codec)
-{
-       lm49453_set_bias_level(codec, SND_SOC_BIAS_OFF);
-       return 0;
-}
-
-static int lm49453_resume(struct snd_soc_codec *codec)
-{
-       lm49453_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       return 0;
-}
-
 /* power down chip */
 static int lm49453_remove(struct snd_soc_codec *codec)
 {
@@ -1416,8 +1404,6 @@ static int lm49453_remove(struct snd_soc_codec *codec)
 
 static struct snd_soc_codec_driver soc_codec_dev_lm49453 = {
        .remove = lm49453_remove,
-       .suspend = lm49453_suspend,
-       .resume = lm49453_resume,
        .set_bias_level = lm49453_set_bias_level,
        .controls = lm49453_snd_controls,
        .num_controls = ARRAY_SIZE(lm49453_snd_controls),