]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: et131x: Remove useless return variables
authorPeter Senna Tschudin <peter.senna@gmail.com>
Tue, 20 May 2014 10:33:45 +0000 (12:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 May 2014 11:43:47 +0000 (20:43 +0900)
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/et131x/et131x.c

index d329cf31436048598f6f0221de7ad4b586c58861..1ac718476edb479ccd706199f0b53be0742c0f43 100644 (file)
@@ -4237,7 +4237,6 @@ static int et131x_ioctl(struct net_device *netdev, struct ifreq *reqbuf,
 static int et131x_set_packet_filter(struct et131x_adapter *adapter)
 {
        int filter = adapter->packet_filter;
-       int status = 0;
        u32 ctrl;
        u32 pf_ctrl;
 
@@ -4288,7 +4287,7 @@ static int et131x_set_packet_filter(struct et131x_adapter *adapter)
                writel(pf_ctrl, &adapter->regs->rxmac.pf_ctrl);
                writel(ctrl, &adapter->regs->rxmac.ctrl);
        }
-       return status;
+       return 0;
 }
 
 /* et131x_multicast - The handler to configure multicasting on the interface */