]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
igb: only use vlan_gro_receive if vlans are registered
authorAlexander Duyck <alexander.h.duyck@intel.com>
Tue, 23 Mar 2010 18:35:18 +0000 (18:35 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Jan 2011 22:43:13 +0000 (14:43 -0800)
commit 31b24b955c3ebbb6f3008a6374e61cf7c05a193c upstream.

This change makes it so that vlan_gro_receive is only used if vlans have been
registered to the adapter structure.  Previously we were just sending all vlan
tagged frames in via this function but this results in a null pointer
dereference when vlans are not registered.

[ This fixes bugzilla entry 15582 -Eric Dumazet]

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/igb/igb_main.c

index 8111776927ae30ffcbc60ffb56daebbe80f744a0..9e3d87abb9ac7987b040298cad28cfe461cc15a7 100644 (file)
@@ -4560,7 +4560,7 @@ static void igb_receive_skb(struct igb_ring *ring, u8 status,
        bool vlan_extracted = (adapter->vlgrp && (status & E1000_RXD_STAT_VP));
 
        skb_record_rx_queue(skb, ring->queue_index);
-       if (vlan_extracted)
+       if (vlan_extracted && adapter->vlgrp)
                vlan_gro_receive(&ring->napi, adapter->vlgrp,
                                 le16_to_cpu(rx_desc->wb.upper.vlan),
                                 skb);