]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: wilc1000: change handle_get_ip_address's return type to void
authorChaehyun Lim <chaehyun.lim@gmail.com>
Mon, 2 May 2016 10:47:49 +0000 (19:47 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 May 2016 21:05:59 +0000 (14:05 -0700)
When handle_get_ip_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index 605cf8fcf599adf6243f5a5d82bd96535b8fa52f..ce1cd688dd294bf4a3c2991fcffaaa3155624d1a 100644 (file)
@@ -374,7 +374,7 @@ static void handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
                netdev_err(vif->ndev, "Failed to set IP address\n");
 }
 
-static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx)
+static void handle_get_ip_address(struct wilc_vif *vif, u8 idx)
 {
        s32 result = 0;
        struct wid wid;
@@ -394,12 +394,8 @@ static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx)
        if (memcmp(get_ip[idx], set_ip[idx], IP_ALEN) != 0)
                wilc_setup_ipaddress(vif, set_ip[idx], idx);
 
-       if (result != 0) {
+       if (result != 0)
                netdev_err(vif->ndev, "Failed to get IP address\n");
-               return -EINVAL;
-       }
-
-       return result;
 }
 
 static s32 handle_get_mac_address(struct wilc_vif *vif,