]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings
authorPhilippe Reynes <tremyfr@gmail.com>
Sat, 18 Jun 2016 21:16:55 +0000 (23:16 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 19 Jun 2016 17:55:16 +0000 (10:55 -0700)
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Acked-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aurora/nb8800.c

index 4989d319e8bfc8b07ede81276a26959cbd2ae801..dc2c35dce21681c6dc3579696dd6caa55ab22ed7 100644 (file)
@@ -1035,26 +1035,6 @@ static const struct net_device_ops nb8800_netdev_ops = {
        .ndo_validate_addr      = eth_validate_addr,
 };
 
-static int nb8800_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
-{
-       struct phy_device *phydev = dev->phydev;
-
-       if (!phydev)
-               return -ENODEV;
-
-       return phy_ethtool_gset(phydev, cmd);
-}
-
-static int nb8800_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
-{
-       struct phy_device *phydev = dev->phydev;
-
-       if (!phydev)
-               return -ENODEV;
-
-       return phy_ethtool_sset(phydev, cmd);
-}
-
 static int nb8800_nway_reset(struct net_device *dev)
 {
        struct phy_device *phydev = dev->phydev;
@@ -1183,8 +1163,6 @@ static void nb8800_get_ethtool_stats(struct net_device *dev,
 }
 
 static const struct ethtool_ops nb8800_ethtool_ops = {
-       .get_settings           = nb8800_get_settings,
-       .set_settings           = nb8800_set_settings,
        .nway_reset             = nb8800_nway_reset,
        .get_link               = ethtool_op_get_link,
        .get_pauseparam         = nb8800_get_pauseparam,
@@ -1192,6 +1170,8 @@ static const struct ethtool_ops nb8800_ethtool_ops = {
        .get_sset_count         = nb8800_get_sset_count,
        .get_strings            = nb8800_get_strings,
        .get_ethtool_stats      = nb8800_get_ethtool_stats,
+       .get_link_ksettings     = phy_ethtool_get_link_ksettings,
+       .set_link_ksettings     = phy_ethtool_set_link_ksettings,
 };
 
 static int nb8800_hw_init(struct net_device *dev)