]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
iio:adc:at91: Relase mutex on error path in at91_adc_read_raw
authorLars-Peter Clausen <lars@metafoo.de>
Tue, 26 Jun 2012 08:43:05 +0000 (10:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Jun 2012 21:57:30 +0000 (14:57 -0700)
This issue was reported by the mini_lock.cocci coccinelle semantic patch.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/adc/at91_adc.c

index 6a084695b77e4b12529306f7fc01b4ddac7ae315..f61780a02374d1f855af861092c3ebae5b35cd80 100644 (file)
@@ -349,9 +349,11 @@ static int at91_adc_read_raw(struct iio_dev *idev,
                                                       st->done,
                                                       msecs_to_jiffies(1000));
                if (ret == 0)
-                       return -ETIMEDOUT;
-               else if (ret < 0)
+                       ret = -ETIMEDOUT;
+               if (ret < 0) {
+                       mutex_unlock(&st->lock);
                        return ret;
+               }
 
                *val = st->last_value;