]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
xtensa: Don't reimplement force_sigsegv()
authorMatt Fleming <matt.fleming@intel.com>
Fri, 19 Aug 2011 16:46:52 +0000 (17:46 +0100)
committerOleg Nesterov <oleg@redhat.com>
Wed, 24 Aug 2011 18:13:18 +0000 (20:13 +0200)
Instead of open coding the sequence from force_sigsegv() just call
it. This also fixes a bug because we were modifying ka->sa.sa_handler
(which is a copy of sighand->action[]), whereas the intention of the
code was to modify sighand->action[] directly.

As the original code was working with a copy it had no effect on
signal delivery.

Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Chris Zankel <chris@zankel.net>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
arch/xtensa/kernel/signal.c

index f2220b5bdce64daff9d0b75306e713159b334502..4f53770c42ec8ffea8de8e76e32ed02ff0579115 100644 (file)
@@ -425,9 +425,7 @@ static void setup_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
        return;
 
 give_sigsegv:
-       if (sig == SIGSEGV)
-               ka->sa.sa_handler = SIG_DFL;
-       force_sig(SIGSEGV, current);
+       force_sigsegv(sig, current);
 }
 
 /*