]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
alpha: Add missing RCU idle APIs on idle loop
authorFrederic Weisbecker <fweisbec@gmail.com>
Wed, 22 Aug 2012 15:27:34 +0000 (17:27 +0200)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 5 Sep 2012 01:12:16 +0000 (18:12 -0700)
In the old times, the whole idle task was considered
as an RCU quiescent state. But as RCU became more and
more successful overtime, some RCU read side critical
section have been added even in the code of some
architectures idle tasks, for tracing for example.

So nowadays, rcu_idle_enter() and rcu_idle_exit() must
be called by the architecture to tell RCU about the part
in the idle loop that doesn't make use of rcu read side
critical sections, typically the part that puts the CPU
in low power mode.

This is necessary for RCU to find the quiescent states in
idle in order to complete grace periods.

Add this missing pair of calls in the Alpha's idle loop.

Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Cc: alpha <linux-alpha@vger.kernel.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Michael Cree <mcree@orcon.net.nz>
Cc: <stable@vger.kernel.org>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
arch/alpha/kernel/process.c

index eac5e0169348de5d8ee27d194f972694b2abeb61..eb9558ce7efdb3de9bd11e96c8c6714840f2375d 100644 (file)
@@ -28,6 +28,7 @@
 #include <linux/tty.h>
 #include <linux/console.h>
 #include <linux/slab.h>
+#include <linux/rcupdate.h>
 
 #include <asm/reg.h>
 #include <asm/uaccess.h>
@@ -54,9 +55,11 @@ cpu_idle(void)
                /* FIXME -- EV6 and LCA45 know how to power down
                   the CPU.  */
 
+               rcu_idle_enter();
                while (!need_resched())
                        cpu_relax();
 
+               rcu_idle_exit();
                schedule_preempt_disabled();
        }
 }